Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved uglify-js from optionalDependencies to peerDependencies #1682

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Moved uglify-js from optionalDependencies to peerDependencies #1682

merged 1 commit into from
Apr 24, 2020

Conversation

Silic0nS0ldier
Copy link
Contributor

@Silic0nS0ldier Silic0nS0ldier commented Apr 24, 2020

Addresses #1488, with this change "uglify-js" will no longer be automatically installed. When this occurs npm install (and some of its analogues) will log a message indicating that then peer dependency was not installed. This behaviour extends to the package with the listed peer dependency (handlebars in this case), as such "uglify-js" was also added to devDependencies so that it is installed for use in tests (with the same version constraint).

No new tests were created as the existing optional dependency tests already correctly covered this scenario (with the "uglify-js" missing scenario addressed via mocks).


PR Checklist

Before creating a pull-request, please check https://github.com/wycats/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • (I hope) Have good commit messages
  • (Already covered) Have tests
  • Have the typings (lib/handlebars.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • (5.0 target, hence pointed to master) Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

@nknapp nknapp merged commit a65a553 into handlebars-lang:master Apr 24, 2020
@nknapp
Copy link
Collaborator

nknapp commented Apr 24, 2020

Thanks for this PR. I don't know how long it will take to publish the 5.0 release, but this definitely is a first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants