Moved uglify-js
from optionalDependencies
to peerDependencies
#1682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1488, with this change "uglify-js" will no longer be automatically installed. When this occurs
npm install
(and some of its analogues) will log a message indicating that then peer dependency was not installed. This behaviour extends to the package with the listed peer dependency (handlebars in this case), as such "uglify-js" was also added todevDependencies
so that it is installed for use in tests (with the same version constraint).No new tests were created as the existing optional dependency tests already correctly covered this scenario (with the "uglify-js" missing scenario addressed via mocks).
PR Checklist
Before creating a pull-request, please check https://github.com/wycats/handlebars.js/blob/master/CONTRIBUTING.md first.
Generally we like to see pull requests that
4.x
-branch contains the latest version. Please target that branch in the PR.